workbench: pass error=NULL to "g_key_file_get_string_list()" for key "Bookmarks" #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…"Bookmarks" The key "Bookmarks" can be missing and that is not an error. So pass "NULL" for parameter "error" on calling "g_key_file_get_string_list()". This prevents multiple error messages from being written to one GErrror and so causing a GLib warning in the debug messages. Fixes geany#714.
|
You don't have to create an issue for each PR if you don't want to. It's nice to let people know you're working on something or to discuss, but for small stuff like this which is uncontroversial and/or you have already fixed, you could just submit the PR by itself. Either way is fine. |
|
I know, thanks. But I rate this and the other little PR as a bug. And I really like to have it as a labeled issue so I can find things easier in the future. |
|
@frlan: could you please label this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key "Bookmarks" can be missing and that is not an error. So pass "NULL" for
parameter "error" on calling
g_key_file_get_string_list(). This prevents multipleerror messages from being written to one
GErrrorand so causing a GLib warning inthe debug messages. Fixes #714.