FIX: Spaces after dots in translatable strings #769
Conversation
|
Wouldn't it be better to move the spaces into line before? |
geanyvc/src/geanyvc.c
Outdated
| @@ -1949,7 +1949,7 @@ plugin_configure(GtkDialog * dialog) | |||
| gtk_widget_set_tooltip_text(widgets.cb_editor_menu_entries, | |||
| _("Whether menu for this plugin are getting placed either " | |||
| "inside tools menu or directly inside Geany's menubar." | |||
| "Will take in account after next start of GeanyVC")); | |||
| " Will take in account after next start of GeanyVC")); | |||
There was a problem hiding this comment.
This is not appropriate: there should be a space between the dot and the next word, and the C string syntax "xxx" "yyy" is equivalent to "xxxyyy", not "xxx yyy". If you really want to move the space, place it after the dot on the previous line.
There was a problem hiding this comment.
Forget my comment, it was absurd, I read the diff the wrong way around.
workbench/src/dialogs.c
Outdated
| @@ -444,7 +444,7 @@ gboolean dialogs_workbench_settings(WORKBENCH *workbench) | |||
| gtk_widget_set_tooltip_text(w_enable_live_update, | |||
| _("If the option is activated (default), then the list of files and the sidebar" | |||
| " will be updated automatically if a file or directory is created, removed or renamed." | |||
| "A manual re-scan is not required if the option is enabled.")); | |||
| " A manual re-scan is not required if the option is enabled.")); | |||
| @@ -443,7 +443,7 @@ gboolean dialogs_workbench_settings(WORKBENCH *workbench) | |||
| ui_table_add_row(GTK_TABLE(table), 1, w_enable_live_update, NULL); | |||
| gtk_widget_set_tooltip_text(w_enable_live_update, | |||
| _("If the option is activated (default), then the list of files and the sidebar" | |||
| " will be updated automatically if a file or directory is created, removed or renamed." | |||
| " will be updated automatically if a file or directory is created, removed or renamed. " | |||
There was a problem hiding this comment.
Ideally the leading space here would also be on the previous line, but that's OK with this.
There was a problem hiding this comment.
Did see the leading space to late. Will change it directly
There was a problem hiding this comment.
It's not a problem as there are many strings like that in the workbench plugin
|
I also updated the strings in the translations to include the space, as it doesn't have to be reviewed by translators (I made sure that the translations didn't have the same dot issue, and they don't): 65475da |
|
I added a small section "Translation" to geany's HACKING file to prevent others from making the same fault as me. |
See diff.