Issue737 treebrowser follow doc fix #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file in tree If the current file path is not part of the current directory, the code starts at / to find the path. However, it always skipped the first path part (i.e. /) and so never matched. This happened most often when Geany's default open directory has no common parts with the file path of the current document (e.g. Geany's default open directory is /tmp and the file path is like /home/user/src/somefile.c).
This is rather a hack than a fix: we ignore the drive letter completely on Windows and use \some\path consequently in the code. This breaks multi drive support for now but fixes many path related features like 'Follow current document' which was also broken before.
|
Ignore 428b6d5, I will replace this commit with a better solution as stripping the drive letter breaks more than it solves. |
|
@eht16 I assume you like to rebase this before merging? |
|
Sure but right now I don't want this merged at all (see my comment above as well as the WIP label). |
|
@eht16 OK. Reopen PR once done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes following the current document path.
As mentioned in #737 this was broken on Windows but actually it was broken on non-Windows as well if the start directory (Geany's default open directory or the project base directory) has no common parts with the current document's file path.
For Windows, there was an additional hack necessary: ignoring the drive letter completely in all checks.
This made it working for the moment but obviously breaks a lot of the plugin's functionality if files on another drive than the current are handled.
This should be fixed properly but since the fact that I don't use the plugin and my available time is limited, I won't do myself.