Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Manager causes Geany to crash when opened more than once at a time #1563

Closed
dmaphy opened this issue Jul 27, 2017 · 3 comments
Closed

Plugin Manager causes Geany to crash when opened more than once at a time #1563

dmaphy opened this issue Jul 27, 2017 · 3 comments
Assignees
@b4n
Labels
bug confirmed A developer reproduced this issue, or it affetcs enough users
Milestone
1.32

Comments

@dmaphy
Copy link
Member

dmaphy commented Jul 27, 2017

Currently Geany allows you to open the Plugin Manager dialog more than once at a time. If you do that, and enable/disable a plugin in one dialog, and then enable/disable plugin in the other dialog, Geany crashes. My personal suggestion to solve this would be to check if an instance of this dialog is already open and, if so, just set the focus on the dialog again and bring it to the foreground.

This issue has been reported against the Fedora package of Geany here:
https://bugzilla.redhat.com/show_bug.cgi?id=1473527

I'm going to close the RedHat bug in favor of this upstream one. :-)
@elextr
Copy link
Member

elextr commented Jul 27, 2017

Confirmed.

IIUC the plugin manager is non-modal so you can change plugin prefs and check their effects with it still open but its not intended to be re-entrant.

Should just de-sensitize tools->Plugin Manager menu item when open.

@elextr elextr added the bug label Jul 27, 2017
@b4n
Copy link
Member

b4n commented Jul 28, 2017

Should just de-sensitize tools->Plugin Manager menu item when open.

I don't think so, it makes some sense to have a mean to call upon the dialog if it's already open, and disabling the item isn't necessarily totally safe if there was another way of triggering it (like keybinding not taking the sensitivity into account).

I like @dmaphy's suggestion better.

@b4n b4n added the confirmed A developer reproduced this issue, or it affetcs enough users label Jul 28, 2017
@b4n b4n added this to the 1.32 milestone Jul 28, 2017
@b4n b4n self-assigned this Jul 28, 2017
b4n added a commit to b4n/geany that referenced this issue Jul 28, 2017
@b4n
Fix crash if plugin manager is opened more than once
1ddff27 
Do not allow more than one plugin manager dialog at a time.  It doesn't
make sense and the code is not fully re-entrant and leads to a crash
toggling plugins in both dialogs.

Fixes geany#1563.
@b4n b4n mentioned this issue Jul 28, 2017
Merged
@elextr
Copy link
Member

elextr commented Jul 28, 2017

ok, fine.

codebrainz pushed a commit that referenced this issue Jul 28, 2017
@b4n @codebrainz
Fix crash if plugin manager is opened more than once (#1564)
03e5bb9 
Do not allow more than one plugin manager dialog at a time.  It doesn't
make sense and the code is not fully re-entrant and leads to a crash
toggling plugins in both dialogs.

Fixes #1563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b4n b4n

Labels
bug confirmed A developer reproduced this issue, or it affetcs enough users
Projects
None yet
Milestone
1.32
Development

No branches or pull requests
3 participants
@dmaphy @b4n @elextr