Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe the default sidebar width is too narrow #3630

Closed
scootergrisen opened this issue Oct 21, 2023 · 7 comments · Fixed by #3637
Closed

Maybe the default sidebar width is too narrow #3630

scootergrisen opened this issue Oct 21, 2023 · 7 comments · Fixed by #3637

Comments

@scootergrisen
Copy link
Contributor

There is enough room to show everything in the picture but some of it is clipped of to the left.

billede

Windows 7.
Geany 2.0.
"Pryce"
(bygget Oct 19 2023 eller efter)
Med afviklingsbibliotekerne GTK+ v3.24.39 og GLib v2.78.0

@elextr
Copy link
Member

elextr commented Oct 21, 2023

It depends on the theme, the sidebar width is set in pixels, but the number of pixels depends on the font and size and the size of a pixel, which is a function of your screen which we don't know.

Also there seems to be a lot of space to the right of Documents label, normally it should only be the same as the space to the left, plus enough for the vertical scrollbar plus enough for the pane handle. Maybe something in the theme is adding padding.

But I doubt anybody keeps the default Geany size, so it probably won't hurt to increase the sidebar default pixel count.

eht16 added a commit to eht16/geany that referenced this issue Oct 22, 2023
This should prevent the sidebar from being cutoff or clipped
of the window. The new value is about 25% of the default
window width.

Closes geany#3630.
@eht16
Copy link
Member

eht16 commented Oct 22, 2023

Well, easy enough. #3637 increases the default sidebar width to about 25% of the default window width.

We could also think about increasing the default window altogether, this is how it looks like with Adwaita now:
Screenshot_2023-10-22_10-56-53
OTOH, as @elextr said, most people won't use such small windows anyway.

eht16 added a commit to eht16/geany that referenced this issue Oct 22, 2023
This should prevent the sidebar from being cutoff or clipped
of the window. The new value is about 25% of the default
window width.

Closes geany#3630.
@jeremy-coleman
Copy link

jeremy-coleman commented Oct 24, 2023

on windows 11 it looks like this by default

image

and fullscreen

image

completely fresh install.

@scootergrisen
Copy link
Contributor Author

Dynamically truncating and adding "..." at the end of text where there is not enough room to display all the text would be nice.
billede

@elextr
Copy link
Member

elextr commented Oct 28, 2023

As @b4n said on #3637 the default width of the search entry is too big, on one of my systems it stops the notebook from hiding the documents tab and showing the tab scroll arrows.

If that was changed and "somebody" made a PR to set ellipsize on the tab labels and the "no symbols found" text then it might be accepted, but seems low priority to me given #3637 increases the initial size of the sidebar to improve the first impression, and after that its in the users hands.

@elextr
Copy link
Member

elextr commented Oct 28, 2023

If "somebody" made a PR to set ellipsize on the appropriate labels it might get accepted.

eht16 added a commit that referenced this issue Oct 28, 2023
This should prevent the sidebar from being cutoff or clipped
of the window. The new value is about 25% of the default
window width.

Closes #3630.
@eht16
Copy link
Member

eht16 commented Oct 28, 2023

As said in #3637, the default sidebar width is increased so that it should match better the default window size.
Further improvements like modifying the entry's minimal size or ellipsizing the tab labels can be done separately if someone considers it important enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants