Custom theming fixes for Adwaita 3.20/GTK 3.20 #1137
Conversation
| base[SELECTED] = "#777711111111" | ||
| # try and remove the entry background image on pixmap engine so that our | ||
| # background color is visible, and we don't end up with white text on white | ||
| # background (workaround for Adwaita 3.20). |
There was a problem hiding this comment.
Why does this affect 3.20? I thought gtk3 didn't use the .gtkrc file?
Adwaita 3.20 on GTK2 uses the pixmap engine to set a background image on all states of all GtkEntries. Earlier versions did the same but with a transparent background, thus not hiding our background color. Fixes geany#1135, fixes geany#1101.
Follows the GTK3 behavior, and avoid text becoming invisible if the selection background is too light (unlikely, but possible).
Custom theming fixes for Adwaita 3.20/GTK 3.20
|
Maybe we should add this to a 1.28.1 release, as quite a few people are likely to suffer from that Adwaita issue? |
|
Would it be worth reporting the breakage to Adwaita also? |
|
As for 1.28.1 release, I have no opinion (except that Adwaita is ugly and I don't understand why anyone would use it :) |
I doubt they would care, but it'd be great if someone tried :) [edit] as it actually breaks existing applications, they may care a little, but that would basically mean they can't use background images anywhere, so I'm not quite sure. |
|
Anybody knows how widely spread is the Adwaita theme outside from Fedora? If it affects Fedora only, I can back port the patch and a Geany release could wait then. |
|
Well, as its the default theme for Gnome I guess it is gonna be available on all Gnome distros, even if the distro defaults to its own hacked theme. |
|
@dmaphy as @elextr said, it's the default GNOME theme so it's likely to affect a lot of people. For example, it affects current Debian testing/unstable. But yeah, I think it's likely to have a large impact, hence why I'm considering a point release might be a good idea. Either way you may want to backport the fix in Fedora until we release it, though, your call. |
Fixes #1135, and
may help for#1101(?)This also restores the custom selection color there too that got lost with GTK 3.20, and adds it to GTK2 too (for some reason it never was there).