Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Show from View menu items #1788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scootergrisen
Copy link
Contributor

The menu is called "View" so the "Show " part of the menu item is not nessesary.

@frlan
Copy link
Member

frlan commented Feb 28, 2018

I don't agree 100% here. But also I don't care much.

@b4n
Copy link
Member

b4n commented Feb 28, 2018

Agreed with Frank. @scootergrisen would you care on elaborating why this change is warranted? IMO it makes it slightly less clear, at least to a casual read, and doesn't really add any burden on the reader -- yet, I'm no HCI expert.

@scootergrisen
Copy link
Contributor Author

scootergrisen commented Feb 28, 2018

Having something like "Show sidebar" don't make super much sense when its something you can toggle.
So it says "Show sidebar" both when its enabled and disabled.
Its like having a light switch with the text "Turn on the light" regardless of the light being on or off.

If you really want to use "Show sidebar" then i guess it should say "Show sidebar" when the sidebar is hidden and "Hide sidebar" when the sidebar is showed.

But since we got a checkmark there is no need for "Show" and "Hide". The checkmark tells the user if its on or off.

When its in the View menu people know the menu items are about viewing something.

There is also some strings starting with "Show " in Preferences - Editor - View under View.
There "Show " could also be removed because they are all under "View".

@elextr
Copy link
Member

elextr commented Feb 28, 2018

Don't really see the point of changing the view menu, a quick unscientific survey of the editor-like apps on my machine show about 50-50 so clearly either works.

Removing the show would IMO make it slightly less clear, having a verb helps. And View is not really the verb I would first think of in English when talking about show/hide, other languages may differ.

But for anyone with some basic UI ability, a checkbox in front of a UI element is pretty obvious what it does (and lets face it Geany is an IDE, if you can't work a UI you won't be much of a programmer). And as its a checkbox the label should not swap from show to hide, for checkboxes the check indicates the state, and the label always indicates the state when the checkbox is checked.

Since the longest item in the menu is "Toggle all additional widgets" removing the shows won't make the menu smaller, so I don't see much point of changing it.

@scootergrisen There is no view that I can see in the preferences dialog, can you be more specific.

@b4n
Copy link
Member

b4n commented Feb 28, 2018

As I see it, the checkbox is selecting [whether or not to] Show [the] sidebar, and it's clearer than just [checkbox] Sidebar.
OTOH, e.g. LibreOffice and GEdit don't have the Show part in their items, so maybe it's common/expected. Yet, I don't see anything about this in e.g. GNOME's HIG.

@scootergrisen
Copy link
Contributor Author

It was "Display", not "View".
show

@elextr
Copy link
Member

elextr commented Feb 28, 2018

OTOH, e.g. LibreOffice and GEdit don't have the Show part in their items, so maybe it's common/expected. Yet, I don't see anything about this in e.g. GNOME's HIG.

Thats the Gnome 3, stupid dumbed down applications HIG :(

And GIMP (the REAL GTK HIG :) uses show.

@elextr
Copy link
Member

elextr commented Feb 28, 2018

@scootergrisen Oh, display.

Actually I'm not sure what those are there for, maybe they just predate the view menu, but they seem to do exactly the same thing. If thats the case then maybe they could be totally removed from the prefs dialog.

Otherwise I kind of think the show should stay in the dialog, the heading is "Display" and it collects a group of "Display" related items, its not an action verb that naturally prepends to the items like menus do.

But to me the whole thing seems to be movement for no purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants