Fix PM button desynchronization and possible crash #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be needed in normal operation, but is safer if the UI gets out of sync for some reason.
When toggling a plugin, we temporarily set the tree store's row entry for the plugin pointer to NULL as we destroy and reload the selected plugin, and its pointer would be invalid in the meantime. This results in the filter we use to display search results to temporarily hide the row, changing the actual number of rows and thus, depending on timing, this will or will not change the selected row (it will when double clicking, not when single-clicking), in a seemingly more or less random fashion as we use a sorted model. Finally, as we manually update the buttons visibility for the toggled plugin (as we otherwise do only for changing selection, which should not happen in this case -- well, most of the time as you can see), this can lead to the buttons to be updated for a now unselected row, getting those out of sync. The fix here is not to actually hide rows with a NULL plugin, because it can only happen in 2 cases, where we actually want to see it: 1. while toggling a plugin, as explained above, in which case it had to match the search already. 2. when there is no plugins and we want to display a "No plugins available" message, and the search should not affect this. This incidentally also fix the "No plugins available" so it's actually visible, instead of always hidden. Fixes geany#1781.
|
Nice commit novel :) |
|
Especially as the actual diff is changing |
|
I did a quick negative and positive test by only changing the Today I also noticed that without the fix sometimes even the plugin below the row I am clicking/double-clicking in gets toggled. |
kugel-
approved these changes
Apr 3, 2018
b4n
added a commit
that referenced
this pull request
Apr 3, 2018
…click Fix PM button desynchronization and possible crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1781, and replaces #1784.
See 373852c for extensive details.