Manually realize the VTE widget on startup #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems OK to me, though I would reference #2813 in the source code comment. It probably won't really hurt even if a fix is made upstream right? |
This should fix crashes when pasting text into the widget before it has been fully realized (e.g. when it was never shown before). Fixes geany#2813.
eht16
force-pushed
the
issue2813_fix_vte_paste_crash
branch
from
e3b00fe
to
7863c2a
Compare
Good idea, done.
Probably, it depends on the potential upstream fix but I guess the risk the change here will make it worse is quite low. |
|
LGBI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix crashes when pasting text into the widget before it has
been fully realized (e.g. when it was never shown before).
Fixes #2813.