Two more Geany icon updates #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After making the bottleneck wider (by shifting the curve to the left), the curve became flatter which looks strange. Make the curve a bit more round in the middle.
The (almost) black color of the inside of the bottleneck is a bit too high contrast and doesn't fit the rest of the icon (the only black part of it). Use the "lamp yellow" as the base and lower the L in HSL representation of the color so it just looks as darker lamp material.
|
You're kinda crazy, you know? :) But LGTM anyway ^^ |
Thats just authentic, all good magik lamps are a bit battered and dirty, thats why their owners rub them to find the Geany :) LGTM. |
|
I gave it one week of testing on myself and I think the icon is OK now. I've regenerated the pngs and ico. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been fighting with my feeling that the icon is slightly wrong after my last update and the rational part of me saying nobody will actually notice. The rational part lost.
After making the bottleneck a bit thicker in the last update the curve going from the tip of the bottleneck to the bottom of the lamp got stretched and as a result, less curved. Now it looks as if the lamp was hit by a hammer from the bottom-left side. In the first patch I made the curve a little more curved.
The second patch changes the black color of the inside of the bottleneck to a dark-lamp color (the black color is a bit disturbing because nothing else is black in the icon).
Before:
After:
(Yes, nobody normal won't notice the difference, it's just me.)
If this is considered OK, I'll regenerate the bitmap icons.