-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(backend-common): Avoid memory accesses on zero size reads #2627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this comment please
gear/lazy-pages/src/host_func.rs
Lines 112 to 114 in 11068bc
// TODO: here we suppose zero byte access like one byte access, because | |
// backend memory impl can access memory even in case access has size 0. | |
// We can optimize this if will ignore zero bytes access in core-backend (issue #2095). |
@grishasobol can you please elabortae on how it has to be changed? I asked you about it above - I do not quite understand how it can be optimised or how the comment has to be changed. |
Ok, leave only the first sentence
We cannot make panic here because we must support old runtimes |
Partially resolves #2095.
It is not quite clear what needs to be changed/optimised in lazy-pages with regards to it. @grishasobol can you please clarify?
@reviewer-or-team