Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backend-common): Avoid memory accesses on zero size writes #2648

Merged
merged 1 commit into from
May 12, 2023
Merged

refactor(backend-common): Avoid memory accesses on zero size writes #2648

merged 1 commit into from
May 12, 2023

Conversation

DennisInSky
Copy link
Member

Resolves #2095.

In addition to taking account of zero size reads (#2627), this PR takes care of zero size writes

@reviewer-or-team

@DennisInSky DennisInSky self-assigned this May 11, 2023
@DennisInSky DennisInSky added the A0-pleasereview PR is ready to be reviewed by the team label May 11, 2023
techraed
techraed approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@techraed techraed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

shamilsan
shamilsan approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@shamilsan shamilsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless as always

@DennisInSky DennisInSky merged commit 0f2d21f into master May 12, 2023
8 checks passed
@DennisInSky DennisInSky deleted the dd/noop-on-zero-site-writes branch May 12, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techraed techraed techraed approved these changes

@shamilsan shamilsan shamilsan approved these changes

@grishasobol grishasobol Awaiting requested review from grishasobol

@breathx breathx Awaiting requested review from breathx

Assignees

@DennisInSky DennisInSky

Labels
A0-pleasereview PR is ready to be reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Take in account zero size memory accesses in sys-calls.
3 participants
@DennisInSky @techraed @shamilsan