Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Implement builtin actor providing bls12-381 #3771

Merged
merged 40 commits into from
Mar 28, 2024
Merged

feat(node): Implement builtin actor providing bls12-381 #3771

merged 40 commits into from
Mar 28, 2024

Conversation

gshep
Copy link
Member

@gshep gshep commented Feb 29, 2024 •
edited
Loading

Resolves #3513

  • decode_vec benchmark since it's required to scale-decode vectors by hand for gas counting
  • crate gear-builtins-bls381 declaring entities for bls12_381 crypto
  • benchmarks for all bls12-381 funcs and corresponding update of weights
  • implementation of the builtin actor functionality

@gear-tech/dev

@gshep gshep added A1-inprogress Issue is in progress or PR draft is not ready to be reviewed D2-node Gear Node C1-feature Feature request A5-dontmerge PR should not be merged yet labels Feb 29, 2024
@gshep gshep self-assigned this Feb 29, 2024
NikVolf
NikVolf reviewed Mar 2, 2024
View reviewed changes
gbuiltins/bls381/src/lib.rs Outdated Show resolved Hide resolved
mertwole
mertwole reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@mertwole mertwole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes about benches

pallets/gear-builtin/src/benchmarking.rs Show resolved Hide resolved
pallets/gear-builtin/src/benchmarking.rs Show resolved Hide resolved
pallets/gear-builtin/src/benchmarking.rs Outdated Show resolved Hide resolved
@breathx
Copy link
Member

breathx commented Mar 13, 2024

rebase and set as ready for review pls @gshep

@gshep gshep marked this pull request as ready for review March 14, 2024 11:20
@gshep gshep changed the title Draft: feat(node): Implement builtin actor providing bls12-381 feat(node): Implement builtin actor providing bls12-381 Mar 14, 2024
@gshep gshep requested review from ekovalev and breathx March 25, 2024 12:12
@breathx breathx added A0-pleasereview PR is ready to be reviewed by the team and removed A3-gotissues PR occurred to have issues after the review labels Mar 26, 2024
breathx
breathx approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, ready to go

gbuiltins/bls381/src/lib.rs Outdated Show resolved Hide resolved
gbuiltins/bls381/src/lib.rs Outdated Show resolved Hide resolved
gbuiltins/bls381/src/lib.rs Outdated Show resolved Hide resolved
utils/wasm-proc/src/main.rs Outdated Show resolved Hide resolved
pallets/gear-builtin/src/benchmarking.rs Show resolved Hide resolved
pallets/gear-builtin/src/benchmarking.rs Show resolved Hide resolved
pallets/gear-builtin/src/tests/bls381.rs Show resolved Hide resolved
pallets/gear-builtin/src/bls12_381.rs Show resolved Hide resolved
pallets/gear-builtin/src/bls12_381.rs Outdated Show resolved Hide resolved
@breathx breathx mentioned this pull request Mar 27, 2024
Open
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Mar 27, 2024
@breathx
Copy link
Member

breathx commented Mar 27, 2024

Merge after #3836 and #3814 are merged

@breathx breathx added the A5-dontmerge PR should not be merged yet label Mar 27, 2024
breathx
breathx approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@gshep gshep merged commit 26a077e into master Mar 28, 2024
11 checks passed
@gshep gshep deleted the gshep/issue-3513-2 branch March 28, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf NikVolf left review comments

@mertwole mertwole mertwole left review comments

@ekovalev ekovalev ekovalev approved these changes

@breathx breathx breathx approved these changes

Assignees

@gshep gshep

Labels
A2-mergeoncegreen PR is ready to merge after CI passes A5-dontmerge PR should not be merged yet C1-feature Feature request D2-node Gear Node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in actor providing bls381
5 participants
@gshep @breathx @ekovalev @NikVolf @mertwole