Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo-bls381 demonstrating interaction with the builtin #3836

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

gshep
Copy link
Member

@gshep gshep commented Mar 25, 2024

@gear-tech/dev

@gshep gshep added A0-pleasereview PR is ready to be reviewed by the team D4-test Autotests, and examples labels Mar 25, 2024
@gshep gshep requested review from ekovalev and breathx March 25, 2024 18:28
@gshep gshep self-assigned this Mar 25, 2024
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

examples/bls381/build.rs Outdated Show resolved Hide resolved

type ArkScale<T> = ark_scale::ArkScale<T, { ark_scale::HOST_CALL }>;

const BUILTIN_BLS381: ActorId = ActorId::new(hex!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we mb add it in gbuiltin crate mb with hint that it needs to be checked on-chain manually if you dont trust?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember we've discussed that already and haven't found suitable solution. So leave it as is for the moment.

gclient/tests/builtin_bls381.rs Outdated Show resolved Hide resolved
@breathx breathx added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Mar 27, 2024
gshep and others added 4 commits March 28, 2024 10:01
Conflicts:
	Cargo.lock
	Cargo.toml
Co-authored-by: LouiseMedova <luisa.medova@gmail.com>
Co-authored-by: LouiseMedova <luisa.medova@gmail.com>
@gshep gshep merged commit 3cc537d into gshep/issue-3513-2 Mar 28, 2024
@gshep gshep deleted the gshep/issue-3513-demo branch March 28, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-mergeoncegreen PR is ready to merge after CI passes D4-test Autotests, and examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants