Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gtest): allow zero balance for exec::exit() #3848

Merged
merged 2 commits into from
Apr 1, 2024
Merged

fix(gtest): allow zero balance for exec::exit() #3848

merged 2 commits into from
Apr 1, 2024

Conversation

StackOverflowExcept1on
Copy link
Member

Resolves #3847

@gear-tech/dev

@StackOverflowExcept1on StackOverflowExcept1on added A0-pleasereview PR is ready to be reviewed by the team D5-tooling Helper tools and utilities labels Mar 30, 2024
@StackOverflowExcept1on StackOverflowExcept1on changed the title Av/gtest exit fix(gtest): allow zero balance for exec::exit() Mar 30, 2024
@breathx
Copy link
Member

breathx commented Mar 30, 2024

It's not actually about keeping something alive, but solves the issue

gshep
gshep approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@gshep gshep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gtest/src/manager.rs Outdated Show resolved Hide resolved
@StackOverflowExcept1on StackOverflowExcept1on added A2-mergeoncegreen PR is ready to merge after CI passes and removed A0-pleasereview PR is ready to be reviewed by the team labels Apr 1, 2024
@StackOverflowExcept1on StackOverflowExcept1on merged commit 30bfd2a into master Apr 1, 2024
12 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/gtest-exit branch April 1, 2024 11:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshep gshep gshep approved these changes

@breathx breathx breathx approved these changes

Assignees
No one assigned
Labels
A2-mergeoncegreen PR is ready to merge after CI passes D5-tooling Helper tools and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gtest is broken for exec::exit()
3 participants
@StackOverflowExcept1on @breathx @gshep