Make StorageTransactionCache clonable if type parameters permit #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breathx
approved these changes
Sep 13, 2023
| @@ -197,6 +197,18 @@ impl<Transaction, H: Hasher> Default for StorageTransactionCache<Transaction, H> | |||
| } | |||
| } | |||
|
|
|||
| impl<Transaction, H: Hasher> Clone for StorageTransactionCache<Transaction, H> | |||
ekovalev
merged commit a6b4202
into
gear-polkadot-v0.9.41-canary-no-sandbox
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need to be able to clone the associated
RuntimeApiinstance while cloning the block builder used to propose a block in order to be able to run the pseudo-inherent at the end of a block with a timeout in a separate thread on top of the overlay changes made by the extrinsics in this block, while keeping the old block builder intact in case we need to fall back to it if the timeout expires.The
RuntimeApiincludes a reference to thesp_state_machine::StorageTransactionCachewhich doesn't implementCloneby default due to its dependent types, but in the real node all the type parameters involved are clonable.