Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scala 2.12 #2106

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Conversation

manuzhang
Copy link
Member

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the commit message is formatted like:
    [GEARPUMP-<Jira issue #>] Meaningful description of pull request
  • Make sure tests pass via sbt clean test.
  • Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.

@manuzhang manuzhang force-pushed the upgrade_scala212 branch 2 times, most recently from efdd32f to 4df115e Compare December 2, 2018 08:15
@codecov
Copy link

codecov bot commented Dec 2, 2018

Codecov Report

Merging #2106 into master will decrease coverage by 71.35%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #2106       +/-   ##
==========================================
- Coverage   71.35%      0%   -71.36%     
==========================================
  Files         174     174               
  Lines        5735     189     -5546     
  Branches      503       9      -494     
==========================================
- Hits         4092       0     -4092     
+ Misses       1643     189     -1454

@manuzhang
Copy link
Member Author

The distribute service example is disabled temporarily for which I opened #2107

@manuzhang
Copy link
Member Author

Not sure why code coverage drops to 0% 😞

@manuzhang manuzhang merged commit 78bed0b into gearpump:master Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant