Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve frame context management when nested withFrame() calls are used #612

Closed
erdi opened this issue Apr 29, 2020 · 0 comments
Closed

Improve frame context management when nested withFrame() calls are used #612

erdi opened this issue Apr 29, 2020 · 0 comments
Labels
Improvement
Milestone
4.0

Comments

@erdi
Copy link
Member

erdi commented Apr 29, 2020 •
edited
Loading

Now that support for switching to parent frame has been added to web driver via WebDriver.TargetLocator.parentFrame() use that instead of WebDriver.TargetLocator.defaultContent() to switch out of the frame at the end of withFrame() method. This will mean that after a nested call to withFrame() the context will be reverted to that of the parent frame and not the top level of the document.
@erdi erdi modified the milestones: 3.5, 4.0 Apr 29, 2020
@erdi erdi changed the title Support nested withFrame() calls Improve frame context management when nested withFrame() calls are used Apr 29, 2020
erdi added a commit to geb/geb that referenced this issue Nov 15, 2020
@erdi
Improve frame context management when nested withFrame() calls are used
ff0d7a8 
Closes geb/issues#612
erdi added a commit to geb/geb that referenced this issue Nov 22, 2020
@erdi
Improve frame context management when nested withFrame() calls are used
b864b49 
Closes geb/issues#612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@erdi