Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete KhmerError from khmer/_khmermodule.cc as it is unused #503

Closed
mr-c opened this issue Jun 19, 2014 · 3 comments
Closed

delete KhmerError from khmer/_khmermodule.cc as it is unused #503

mr-c opened this issue Jun 19, 2014 · 3 comments
Labels
C++ low-hanging-fruit
Milestone
1.2 Release

Comments

@mr-c
Copy link
Contributor

mr-c commented Jun 19, 2014

and the references to it in init_khmer()
@mr-c mr-c added this to the 1.1.1+ Release milestone Jun 19, 2014
@mr-c mr-c added the C++ label Jul 17, 2014
@mr-c mr-c mentioned this issue Jul 17, 2014
Closed
@drlabratory
Copy link
Contributor

I'll give this a go. So just delete and retest to make sure nothing breaks?

@ctb
Copy link
Member

ctb commented Jul 22, 2014

On Tue, Jul 22, 2014 at 07:57:56AM -0700, Jeramia Ory wrote:

I'll give this a go. So just delete and retest to make sure nothing breaks?

yep!

@drlabratory drlabratory mentioned this issue Jul 22, 2014
Merged
@mr-c
Copy link
Contributor Author

mr-c commented Jul 23, 2014

Fixed by #540

@mr-c mr-c closed this as completed Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ low-hanging-fruit
Projects
None yet
Milestone
1.2 Release
Development

No branches or pull requests
4 participants
@ctb @mr-c @drlabratory @themangoemoji