Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of sandbox files #589

Merged
merged 8 commits into from Sep 9, 2014
Merged

cleanup of sandbox files #589

merged 8 commits into from Sep 9, 2014

Conversation

ctb
Copy link
Member

@ctb ctb commented Sep 2, 2014

classification, documentation, and/or removal. See #471 and also http://github.com/ged-lab/khmer-recipes.

@ctb
Copy link
Member Author

ctb commented Sep 2, 2014

@mr-c, does this:

https://github.com/ged-lab/khmer/blob/cleanup/sandbox/sandbox/README.rst

seem like a good way to reference old scripts? See bottom for what the whole file will look like: one-liner descriptions, plus (for the ones we're keeping) links to recipes.

Specific questions:

  • Is sandbox/README.rst the right place to put this info?
  • Is that a good way to reference commits where files can be found? Or should I just link directly to repo at that point? Or?

@ctb
Copy link
Member Author

ctb commented Sep 2, 2014

Hey @mr-c, given the extent of the triage (over 100 files removed), I'm thinking it might be worth merging this in sooner rather than later. Once the ChangeLog is updated and sandbox/README.rst is fixed up, I think it'd be ready for a provisional merge. What do you think?

1 similar comment
@ctb
Copy link
Member Author

ctb commented Sep 2, 2014

Hey @mr-c, given the extent of the triage (over 100 files removed), I'm thinking it might be worth merging this in sooner rather than later. Once the ChangeLog is updated and sandbox/README.rst is fixed up, I think it'd be ready for a provisional merge. What do you think?

@mr-c
Copy link
Contributor

mr-c commented Sep 4, 2014

I'm okay with merging sooner rather than later. I'd recommend embedding at least a link to the commit and some historical context to the directory as a whole at the top.

@ctb
Copy link
Member Author

ctb commented Sep 7, 2014

On Thu, Sep 04, 2014 at 04:54:44PM -0700, Michael R. Crusoe wrote:

I'm okay with merging sooner rather than later. I'd recommend embedding at least a link to the commit and some historical context to the directory as a whole at the top.

Ready for preliminary review. Suggestions on what to do in ChangeLog welcome
-- should we list all removed files for later greppability?

@mr-c
Copy link
Contributor

mr-c commented Sep 8, 2014

Looks good. Yes, lets add the names of all deleted scripts to the ChangeLog for grep-ability.

@ctb
Copy link
Member Author

ctb commented Sep 9, 2014

Will merge as soon as tests pass.

ctb added a commit that referenced this pull request Sep 9, 2014
@ctb ctb merged commit ca5667b into master Sep 9, 2014
@ctb ctb deleted the cleanup/sandbox branch September 9, 2014 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants