-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jruby pg #1
Jruby pg #1
Conversation
use pg_config to determine postgresql bin directory and use it if available. Also, if we're running on a no fork system redirect the output of the commands. Otherwise pg_ctl won't leave the shell process group and block the specs from finishing
Do you have any insight on how to get the specs running? I've got a fresh JRuby installed via RVM and it won't build the gem. Here are the outputs from the
|
Seems like the Rakefile dependencies is broken. You should be able to run |
@jvshahid Great work! Unfortunatelly there is currently something wrong with the
You added PG::Constants::OID_* values to the jruby part. This is something that is also part of the type casting branch I experiment since a while, but the OIDs are fetched from the database there. Possibly we could add PG::Constants::OID_* to the C extension nevertheless. I still have to inspect the Rakefile changes. In any case it's a good way to take the path for initdb and pg_ctl from pg_config. The error file generator is possibly better placed in All in all I don't have an objection to integrate this. The only thing I worry about is how we should go forward with the type casting in pg. It is probably a bunch of work to implement it equally in Java. |
Any updates on this? I'm looking to switch a rails application from MRI 2.1 to JRuby, but we need decent postgresql support. If it would help, we could provide some funds for someone to work on this. |
pg_config is usually in the path of many distros, as soon as postgresql-client tools are installed, but server commands are not. That's why we always had to adjust the PATH accordingly. Determining the path of these commands automatically makes testing easier. Extracted from ged#1
It's a bunch of work incorporated into this PR, but I think the approach to add a JRuby extension to ruby-pg is no longer followed and it can be closed. @jvshahid I read about better PostgreSQL support for rails-7 on JRuby, but didn't find a link to any code. What is it about? Should I add a pointer to the README of ruby-pg? |
I thought I should open a pr to get the ball rolling. This still needs some work, there are currently 9 failures that I need to fix. Feedback is welcome, specially with the changes to the Rakefile, etc.