Fix/illegal cp flag #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… utilizing rsync, which both *nixes should have, gives access to the -u flag that acts in the same manner as "cp -u" would. http://stackoverflow.com/questions/1132508/how-to-emulate-cp-update-behavior-on-mac-os-x
|
I don't think we want to assume everybody has rsync installed. We'll just dispense with the -u flag completely, and overwrite blindly. This is okay behavior, since it's safe to assume people have their app source under revision control. I applied a patch that fixes this in c0d03e3, and pushed. Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out the commit message. I couldn't think of any reason why not to use rsync in this case since the usage of the -u flag replicates cp functionality.
Started this which I'll add actual tests to as I have time :: http://github.com/cookrn/geddy-gen_tests