Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Search Engine to the repo #2196

Merged
merged 20 commits into from
May 17, 2024

Conversation

Xceptions
Copy link
Contributor

This PR contributes a search engine that can be used to search for documents that contain a search term

Copy link
Contributor

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE NUMBER OF COMMITS ARE MUCH HIGHER FOR THIS SIMPLE PROGRAMMING SCRIPT FILES.

TRY TO SQUASH IT.

THEN COMMIT AGAIN, BY REDUCING THE NUMBER OF COMMITS.

To minimize the number of commits while ensuring that the same work and file changes are made, you can squash the commits related to a single feature into a single commit. Here's how you can do it:

  1. Identify Related Commits: Review the commits related to the search engine feature. These are the commits that add, modify, or delete files related to the search engine functionality.

  2. Squash Commits: Use interactive rebase to squash these commits into one. You can do this by running the following command in your terminal:

    git rebase -i HEAD~<number_of_commits>

    Replace <number_of_commits> with the number of commits you want to squash. This command will open an editor where you can specify how to rebase the commits. Change "pick" to "squash" for all but the first commit, save, and exit the editor.

  3. Rewrite Commit Message: After squashing the commits, Git will prompt you to write a new commit message. Write a descriptive message summarizing all the changes made by those squashed commits.

  4. Force Push: Once you've rewritten the commit history, force push the changes to your branch:

    git push origin <branch_name> --force

    Replace <branch_name> with the name of your branch.

By squashing related commits into one, you can maintain a cleaner commit history while still preserving the changes and work done.

@geekcomputers geekcomputers merged commit 5ef5a07 into geekcomputers:master May 17, 2024
@Xceptions
Copy link
Contributor Author

Hi, @geekcomputers , kindly see that @NitkarshChourasia left a comment for me to squash some commits, I planned on working on that this weekend, but I see that you have merged the PR regardless. Will the squashing still be needed?

@NitkarshChourasia
Copy link
Contributor

Hi, @geekcomputers , kindly see that @NitkarshChourasia left a comment for me to squash some commits, I planned on working on that this weekend, but I see that you have merged the PR regardless. Will the squashing still be needed?

No

@NitkarshChourasia
Copy link
Contributor

It is to reduce the number of commits, so as to handle it in future. If needed.
Next time try to squash them when the commits are huge in numbers as per to the features introduced. @Xceptions

Thank you,
@NitkarshChourasia

@Xceptions
Copy link
Contributor Author

okay thank you.

Looking to make more contributions soon

@NitkarshChourasia
Copy link
Contributor

NitkarshChourasia commented May 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants