This repository has been archived by the owner on May 31, 2021. It is now read-only.
Fixes #45: Agree to Apple Xcode license agreements in Homebrew setup. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead, document how this is achieved, link to official documentation NOTE: I would like to have Ansible print explicitly that it skips over package / tap / cask setup tasks if the corresponding list is empty instead of just printing the task and then moving on; this seems more in line with the other tasks. However, a when statement is not evaluated if a list iterated over using with_items is empty; see also http://stackoverflow.com/a/35471907 possibly related: ansible/ansible#1408
|
Sorry for sending all my changes in a single pull request. If someone could let me know how to split up multiple commits into multiple pull requests, I'd be most grateful. |
|
The pull request Travis check fails with I don't know what to do about that. |
|
To split to multiple PR's, you'd need a branch per change (then you can submit a PR per branch). If you can do that, please do so, and that way I can merge in the defaults changes separately (since that's a lot simpler/easier to test :) |
|
closing this pull request, will open one per issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested to work OK on setup described at #45 with target machine reset to snapshot taken right after initial installation.