Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pool associations #84

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

dlerch-transporeon
Copy link
Contributor

the pool directive was introduced in #77
in order to work properly, the nopeer restriction should be allowed for sources
See further information:
#77
https://bugs.ntp.org/show_bug.cgi?id=2657

the pool directive was introduced in geerlingguy#77
in order to work properly, the nopeer restriction should be allowed for sources
See further information:
geerlingguy#77
https://bugs.ntp.org/show_bug.cgi?id=2657
@dlerch-transporeon
Copy link
Contributor Author

any updates here?

@stuart-c
Copy link

stuart-c commented Nov 3, 2020

@geerlingguy would it be possible to merge this PR? I'm also seeing the same problem and have verified this PR fixes it...

@RyuCaelum
Copy link

@geerlingguy Could you have a look at this PR? Also would like to have this merged

@RyuCaelum
Copy link

@geerlingguy

arin-mirror pushed a commit to arineng/ansible-role-ntp that referenced this pull request Feb 5, 2021
@@ -30,6 +30,9 @@ pool {{ item }}
# permit the source to query or modify the service on this system.
restrict default nomodify notrap nopeer noquery

# Allow pool associations
restrict source nomodify notrap noquery
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this addition something that could make NTP's behavior different for existing role users who upgrade them suddenly have this new line in their config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will make the pool associations work again. see the bug description for further information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #85

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is that nopeer prevents using servers from a pool directive. The man 5 ntp.conf reads:

restrict ...
...
nopeer ... It also includes pool associations, so if you want to use servers from a pool directive and also want to use nopeer by default, you'll want a restrict source ... line as well that does not include the nopeer directive.

So this PR fixes the problem with ntpd >=4.2.7 exactly as it described in the manual.

RealOrangeOne added a commit to RealOrangeOne/infrastructure that referenced this pull request Mar 13, 2021
Manually apply geerlingguy/ansible-role-ntp#84, so machines actually update themselves via NTP
@dlerch-transporeon
Copy link
Contributor Author

Hi @geerlingguy, last try from my side, can we fix this issue after 7 months?

@geerlingguy geerlingguy merged commit 920ff29 into geerlingguy:master Apr 19, 2021
danielrobbins pushed a commit to funtoo/kit-fixups that referenced this pull request Apr 30, 2021
…FL-8251-ntp-4.2.8_p15-not-synchronizing-clock to master

Squashed commit of the following:

commit e2d740d9dc091a728a14fd071a78a914ae310eb9
Author: Saulius Gurklys <s4uliu5@gmail.com>
Date:   Sat Apr 3 12:12:17 2021 +0300

    FL-8251: fix ntp-4.2.8_p15 clock sync when "pool" is used

    https://bugs.ntp.org/show_bug.cgi?id=2657
    geerlingguy/ansible-role-ntp#85
    geerlingguy/ansible-role-ntp#84
Georgiy-Tugai added a commit to Georgiy-Tugai/vyos-1x that referenced this pull request Oct 11, 2021
As of NTP 4.2.7, 'nopeer' also blocks pool associations.

See https://bugs.ntp.org/show_bug.cgi?id=2657

See also geerlingguy/ansible-role-ntp#84
Georgiy-Tugai added a commit to Georgiy-Tugai/vyos-1x that referenced this pull request Oct 13, 2021
As of NTP 4.2.7, 'nopeer' also blocks pool associations.

See https://bugs.ntp.org/show_bug.cgi?id=2657

See also geerlingguy/ansible-role-ntp#84
Georgiy-Tugai added a commit to Georgiy-Tugai/vyos-1x that referenced this pull request Oct 13, 2021
As of NTP 4.2.7, 'nopeer' also blocks pool associations.

See https://bugs.ntp.org/show_bug.cgi?id=2657

See also geerlingguy/ansible-role-ntp#84
c-po pushed a commit to c-po/vyos-1x that referenced this pull request Oct 13, 2021
As of NTP 4.2.7, 'nopeer' also blocks pool associations.

See https://bugs.ntp.org/show_bug.cgi?id=2657

See also geerlingguy/ansible-role-ntp#84

(cherry picked from commit 854c68d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants