Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.0 #64

Merged
merged 7 commits into from
Mar 18, 2021
Merged

Add support for PHP 8.0 #64

merged 7 commits into from
Mar 18, 2021

Conversation

wells
Copy link
Contributor

@wells wells commented Mar 18, 2021

Adds remi-php80 and such.

@geerlingguy
Copy link
Owner

Hmm... the test is failing on:

Package 'php8.0-json' has no installation candidate

Looks like: oerdnj/deb.sury.org#1439 (comment)

JSON is now always included, so no php8.0-json, it's always there

So we'll need to make sure if php_version == '8.0' (or better yet, if it's major version is 8 or more), the json package is removed by default...

@geerlingguy
Copy link
Owner

(Big +1 to getting this added though... we need PHP 8 support :D

@geerlingguy
Copy link
Owner

Haha, well... you pushed that commit while I was typing.

@wells
Copy link
Contributor Author

wells commented Mar 18, 2021

Hey Jeff. Yes sir. Just added a set_fact for Debian builds. Fingers crossed. 🥳

tasks/main.yml Outdated Show resolved Hide resolved
@geerlingguy geerlingguy merged commit 6a9b4b6 into geerlingguy:master Mar 18, 2021
@wells wells deleted the feature/php-8 branch March 18, 2021 21:30
@geerlingguy
Copy link
Owner

Thanks!

@itsmebhupendra
Copy link

I am still facing the same issue for "php8.1-json" while vagrant up.
My configuration:
"geerlingguy/drupal-vm": "^6.0" in composer.json which installs version "6.0.4".

Inside config.yml:
"vagrant_box: geerlingguy/ubuntu2004"
php_version: '8.1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants