Apply configurations to all possible conf directories on Debian

[oxyc]

geerlingguy/ansible-role-php-xdebug#26 (comment)

[geerlingguy]

Since it's just one item, let's just use the shorthand:

  with_items: "{{ php_conf_paths }}"

[oxyc]

I had to add this variable because of Debain madness.

[oxyc]

Hmmm:

Currently RedHat has:

__php_conf_path: /etc
__php_fpm_pool_conf_path: "/etc/php-fpm.d/www.conf"

But then this is in php-fpm.conf:

include={{ php_conf_path }}/fpm/pool.d/*.conf

Edit: Also where should --with-config-file-path be pointed when installing from source? It's a mute task as it's done later in configure.yml right?

[oxyc]

Tests confirm that --with-config-file-path is mute. It's overridden anyways. The RedHat pool.d I still need to verify

[geerlingguy]

Looks good to me?

[oxyc]

I'm not sure about the source install on RedHat. I'll run some tests to make sure.

Are there two conf paths on RedHat? From the previous config it seems there is both /etc/fpm and /etc/php-fpm.d

[geerlingguy]

@oxyc - K, pending those results, I'll merge it in tonight or tomorrow morning. Working on a few other roles tonight.

[oxyc]

Not sure I'll get it done tonight. Found some other bugs as well. Really need to upgrade my internet connection so I can start building these containers locally..

[oxyc]

Seems that the /etc/php5/fpm/pool.d/www.conf does not exist when installing from source with --with-fpm. Not on RedHat either. Did this use to work? I have to look into it more later

[geerlingguy]

Don't have time to dig in now, but did we create that file using template?

[oxyc]

We do not. It's available after installed from a package manager but not when installed from source.

Also the file has never been included on RedHat (the path was incorrect in php-fpm.conf).

[geerlingguy]

I'm also looking into this now (a little at least) as I'm working on some drupal-pi improvements, as I'm seeing the same:

Destination /etc/php5/fpm/pool.d/www.conf does not exist !

[oxyc]

I had to give up. Think I need to install php 7.0 and play around properly. I think this was broken before this patch though. Currently I need a break from these crazy configs (I also read the paths have changed AGAIN for php7 on ubuntu when installed from the ppa...)

Here's a few notes from things I attempted (still couldn't solve it though). Maybe you can solve it.

oxyc@32d91a5
Running systemctl status php-fpm.service reported this path was the one included. Still same error though so maybe it's not needed.

oxyc@f248498 Made sure the pool conf existed before modifying. Guess this is incorrect and we should add the file somehow.

oxyc@5e116f1
Fixed the path to the conf paths in php-fpm.conf. RedHat had it incorrect.

oxyc@72873e8
I think this was broken because the variable was used in install-from-source.yml already.

[geerlingguy]

It was definitely broken before this PR; I'm using that for testing on Debian Jessie, and it's breaking at the same spot. So I'll see if I can at least get that fixed.

I think we're safe to merge this, then fix the install-from-source issues in a separate PR, what do you think?

[oxyc]

I think it's safe. There's one questionable commit that might affect php7 with fpm though 9eadfc1, this change was what prompted me to test php7.