feat: solr listen on custom network interface #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @geerlingguy anything else to be done from my side to make this PR happen? |
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
|
According to https://ansible.jeffgeerling.com/ you still maintain this role so this PR could be merged. |
geerlingguy
reviewed
Jul 30, 2024
| - solr_jetty_host == '127.0.0.1' | ||
|
|
||
| # Create cores also when solr is listening on custom network interface. Just for solr 9.3.0 and higher. | ||
| - include_tasks: cores-post93.yml |
There was a problem hiding this comment.
What's the requirement for a separate cores task file here? I don't think that was explicitly explained but it includes a bit of duplicate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solr_jetty_host.-hhost parameter in solr create script.