Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Enable linked_clone on versions greater than 1.8. #1528

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

thom8
Copy link
Collaborator

@thom8 thom8 commented Aug 23, 2017

Linked clones are only enabled on vagrant versions 1.8.x, updates to enable of all versions greater than 1.8

@geerlingguy
Copy link
Owner

Just because it's late and I don't have the proper context—what wasn't working with the current syntax (v.linked_clone = true if Vagrant::VERSION =~ /^1.8/)?

@geerlingguy
Copy link
Owner

I mean, technically I think Drupal VM now requires 1.8.x+... so we could just drop the entire conditional and make it true in all cases :)

@thom8
Copy link
Collaborator Author

thom8 commented Aug 25, 2017

It wasn't matching on 1.9.0 and above but happy to update to always true

@geerlingguy
Copy link
Owner

@thom8 ah, I see. Yeah, let's just go with true now, since anyone running < 1.8 would hit some weird issues otherwise.

@thom8
Copy link
Collaborator Author

thom8 commented Aug 25, 2017

All done and passing.

@oxyc
Copy link
Collaborator

oxyc commented Sep 18, 2017

ping @geerlingguy please merge this PR if you're planning on a release 😄

~: df -h
Filesystem      Size   Used  Avail Capacity iused      ifree %iused  Mounted on
/dev/disk1     233Gi  226Gi  6.3Gi    98% 3317028 4291650251    0%   /

@geerlingguy geerlingguy merged commit 036e33e into geerlingguy:master Sep 26, 2017
@geerlingguy
Copy link
Owner

/me promises to tag a release soon. Finally had a couple days with nothing in prod environments blowing up, nor DrupalCamps that needed tending to :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants