Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Preserve file permission when installing using composer project #1817

Closed

Conversation

hansfn
Copy link

@hansfn hansfn commented Aug 27, 2018

Composer project ensures that the files directory (and maybe the sync directory when my PR gets approved) has correct permission. However, the build-composer-project task uses cp -r which doesn't preserve permission. Since umask is 022 it kills the writable bits. The easy fix is to add -p to the cp command.

PS! Windows users that uses the default vagrant_synced_folders setting doesn't experience this problem as the sync forces writable files and directories on Linux - probably because the different permission model on Linux and Windows. It took me a while to understand what was going on when I disabled syncing (to get better performance) and Drupal suddenly lost all styling ...

@geerlingguy
Copy link
Owner

@hansfn - Thanks so much for the PR, and the excellent, concise description! Could you please file the same PR against the upstream geerlingguy.drupal repository here: https://github.com/geerlingguy/ansible-role-drupal

Then I'll tag a new release of that project, and include the updated version into Drupal VM. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants