Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve file permission when installing using composer project #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hansfn
Copy link
Owner

@hansfn hansfn commented Oct 18, 2018

(This is a repost of geerlingguy/drupal-vm#1817 as requested by geerlingguy.)

Composer project ensures that the files directory (and maybe the sync directory when my PR gets approved) has correct permission. However, the build-composer-project task uses cp -r which doesn't preserve permission. Since umask is 022 it kills the writable bits. The easy fix is to add -p to the cp command.

PS! Windows users that uses the default vagrant_synced_folders setting doesn't experience this problem as the sync forces writable files and directories on Linux - probably because the different permission model on Linux and Windows. It took me a while to understand what was going on when I disabled syncing (to get better performance) and Drupal suddenly lost all styling ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant