Preserve file permission when installing using composer project #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a repost of geerlingguy/drupal-vm#1817 as requested by geerlingguy.)
Composer project ensures that the files directory (and maybe the sync directory when my PR gets approved) has correct permission. However, the build-composer-project task uses
cp -r
which doesn't preserve permission. Since umask is 022 it kills the writable bits. The easy fix is to add -p to the cp command.PS! Windows users that uses the default vagrant_synced_folders setting doesn't experience this problem as the sync forces writable files and directories on Linux - probably because the different permission model on Linux and Windows. It took me a while to understand what was going on when I disabled syncing (to get better performance) and Drupal suddenly lost all styling ...