Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the _get_intra_event_std function of ASK14 (GMPE) #3270

Closed
g-weatherill opened this issue Nov 21, 2017 · 1 comment
Closed

Change the _get_intra_event_std function of ASK14 (GMPE) #3270

g-weatherill opened this issue Nov 21, 2017 · 1 comment

Comments

@g-weatherill
Copy link
Collaborator

g-weatherill commented Nov 21, 2017

In the Abrahamson et al (2014) GMPE the _get_intra_event_std function raises an error if the phi_al term is less than the phi_amp term to avoid taking the square root of a negative number (https://github.com/gem/oq-engine/blob/master/openquake/hazardlib/gsim/abrahamson_2014.py#L364). This situation happens for IMTs with periods longer than 5 and for magnitudes smaller than about 4.3 - 4.4.

The authors of the GMPE have addressed this in their hazard code, and simply set phi_amp to be 0.99 * phi_al in this circumstance (https://github.com/abrahamson/HAZ/blob/master/HAZ%20files/NGAWest2.F#L3098). As raising an error causes the calculation to fail for reasons that might be cryptic to the users, I recommend to adopt the same adjustment here rather than raising an error.

@mmpagani
Copy link
Member

mmpagani commented Dec 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants