Fixes ASK14 GMPE behaviour to remove ValueError #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM on my part |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3270
When presented with small magnitudes at long periods the Abrahamson et al. (2014) GMPE provides erroneous (i.e. complex) values for intra-event standard deviation. Currently this is caught by raising a ValueError, breaking the calculation. However, as noted in #3270 the GMPE authors themselves catch this case by reducing the
phi_ampterm so that it is fractionally smaller thanphi_al, preventing this from happening. The PR implements this adjustment.