-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvm config scripts do not work properly #669
Comments
Merged
Merged
BobbyRBruce
added
the
configs
gem5's Preprepared Python Configuration scripts. Typically found in "configs"
label
May 13, 2024
BobbyRBruce
pushed a commit
that referenced
this issue
May 13, 2024
These changes to sweep and sweep_hybrid for NVM allow them to run. I'm not an expert on this, so I'm not sure if these are technically correct, but they no longer fail when running `build/X86/gem5.opt configs/nvm/sweep.py` and `build/X86/gem5.opt configs/nvm/sweep_hybrid.py` GitHub Issue: #669
I believe this is fixed by #1114 . Closing. |
BobbyRBruce
pushed a commit
to BobbyRBruce/gem5
that referenced
this issue
May 25, 2024
These changes to sweep and sweep_hybrid for NVM allow them to run. I'm not an expert on this, so I'm not sure if these are technically correct, but they no longer fail when running `build/X86/gem5.opt configs/nvm/sweep.py` and `build/X86/gem5.opt configs/nvm/sweep_hybrid.py` GitHub Issue: gem5#669
hnpl
pushed a commit
to hnpl/gem5
that referenced
this issue
Jun 9, 2024
These changes to sweep and sweep_hybrid for NVM allow them to run. I'm not an expert on this, so I'm not sure if these are technically correct, but they no longer fail when running `build/X86/gem5.opt configs/nvm/sweep.py` and `build/X86/gem5.opt configs/nvm/sweep_hybrid.py` GitHub Issue: gem5#669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The given script
configs/nvm/sweep.py
andconfigs/nvm/sweep_hybrid.py
do not work properly.Affects version
The latest version: Version 23.0.1.0
gem5 Modifications
N/A
To Reproduce
Steps to reproduce the behavior. Please assume starting from a clean repository:
/usr/bin/env python3 $(which scons) build/X86/gem5.opt -j32
build/X86/gem5.opt configs/nvm/sweep.py
orbuild/X86/gem5.opt configs/nvm/sweep_hybrid.py
Terminal Output
and
command line: build/X86/gem5.opt configs/nvm/sweep_hybrid.py fatal: This script assumes the controller is a HeteroMemCtrl subclass
Host Operating System
Ubuntu 20.04.3 LTS
Host ISA
X86
Compiler used
gcc9.4.9, Python 3.8.10
Additional information
I think the problem lies in the memory creation process in
configs/common/MemConfig.py
does not match the expectations of memory creation inconfig/nvm
. For example, inconfigs/nvm/sweep.py
, line118:the script assumes
system.mem_ctrl[0].dram
will store nvm interface, but inconfigs/common/MemConfig.py
, line256, there is:it just put nvm_intf in nvm. However, simply change the above
mem_ctrl.nvm
tomem_ctrl.dram
does not solve the problem, and will cause other errors.The text was updated successfully, but these errors were encountered: