Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "python/m5/info.py" #89

Closed
BobbyRBruce opened this issue Jul 14, 2023 · 5 comments
Closed

Remove "python/m5/info.py" #89

BobbyRBruce opened this issue Jul 14, 2023 · 5 comments

Comments

@BobbyRBruce
Copy link
Member

This file is automatically generated during compilation and contains a copy of the LICENSE, COPYING, and README.md, which is then compiled into the gem5 binary.

As pointed out here: #71 (comment), this is not needed and should probably be removed to avoid complexity.

@andysan
Copy link
Contributor

andysan commented Jul 18, 2023

Including licenses is pretty standard and something we might want to keep. The current implementation isn't that useful though since it doesn't aggregate all of the various licenses (e.g., from ext) covering gem5. On the other hand, I can't think of any use case where anyone would be shipping gem5 binaries, so it might not be very relevant.

@BobbyRBruce
Copy link
Member Author

Including licenses is pretty standard and something we might want to keep. The current implementation isn't that useful though since it doesn't aggregate all of the various licenses (e.g., from ext) covering gem5. On the other hand, I can't think of any use case where anyone would be shipping gem5 binaries, so it might not be very relevant.

Good point.

The --copyright argument, gem5.opt --copyright, currently provides users with info on gem5 licensing/copyright which includes mention of the "ext" licenses and the slight variances in license in gem5. I'm not sure if this is sufficient to count as a license, but perhaps it could be expanded to do so?

Sidenote: The --copyright argument text appears to have been untouched in some time, the stated copyrights don't appear to have been updated in over 5 years.

@powerjg
Copy link
Contributor

powerjg commented Jul 18, 2023

Displaying a single line or two for the license makes sense. I don't know of many tools (I can't find any on my Linux box with a cursory look) which have a --copyright option that displays the entire license text. I don't think that we need a --copyright option.

Of course, if anyone distributed a gem5 binary they would also need to distribute the copyright files. But that would be up to them. I think it's odd to embed that in the binary.

@andysan
Copy link
Contributor

andysan commented Jul 19, 2023

It might be less common in command line tools, but GUI applications typically do include full licenses. For example, Firefox uses the magic URL about:license to show all of the licenses covering a specific Firefox build. I'm pretty sure I have seen that in other GUI tools like KiCad and FreeCAD as well.

@BobbyRBruce
Copy link
Member Author

Closing due to lack of agreement on how best to do this. Not an important change.

@BobbyRBruce BobbyRBruce closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
cyyself pushed a commit to cyyself/gem5 that referenced this issue Apr 30, 2024
arch-riscv: Fix syncing store-conditional info from dut to ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants