Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext: Specialize GDBSignal MACRO to gem5 #209

Merged
merged 1 commit into from
Aug 24, 2023
Merged

ext: Specialize GDBSignal MACRO to gem5 #209

merged 1 commit into from
Aug 24, 2023

Conversation

BobbyRBruce
Copy link
Member

The goal is to fix this issue which appears to be affects some Apple users: #94.

By specializing the EXC_* to gem5 we avoid the name conflicts plagiing some users.

Change-Id: I031f7110b4b4ae82677b6586903cd57b22ca2137

@BobbyRBruce
ext: Specialize GDBSignal MACRO to gem5
6f7fc51 
The goal is to fix this issue which appears to be affects some Apple
users: gem5#94.

By specializing the `EXC_*` to gem5 we avoid the name conflicts plagiing
some users.

Change-Id: I031f7110b4b4ae82677b6586903cd57b22ca2137
@BobbyRBruce BobbyRBruce added ext Components external to gem5 such as third-party code. Typically found in "ext" gdb The GNU Debugger compilation error labels Aug 22, 2023
@BobbyRBruce BobbyRBruce mentioned this pull request Aug 22, 2023
Closed
@BobbyRBruce BobbyRBruce linked an issue Aug 22, 2023 that may be closed by this pull request
macOS build failure due to conflicting defines in gdbremote/signals.hh #94
Closed
@powerjg
Copy link
Contributor

powerjg commented Aug 22, 2023

If it's possible, I would prefer somehow not including mach/exception_types.h I'm not sure why/how that file is included. It's odd that this MacOS-unique file is included in the gem5 build.

That said, I just spent some time digging into the use of GDBSignal and this change should not break anything, so I would be OK with it going in as-is.

BTW, here's the commit where this was introduced: 7230a3e

@BobbyRBruce
Copy link
Member Author

@powerjg : This appears to fix the issue they are facing. Your the assignee here so i'll leave it to you, but my personal vote is to get this in. It may be inelegant but I don't see how it could introduce any problems.

@shingarov shingarov self-requested a review August 24, 2023 06:02
shingarov
shingarov approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@shingarov shingarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was affecting me as well; I have verified that the proposed diff resolves the issue for me. Let's merge this PR.

@BobbyRBruce BobbyRBruce merged commit 2d9ad02 into gem5:develop Aug 24, 2023
5 checks passed
@BobbyRBruce BobbyRBruce deleted the fix-mach-exception-types-conflic branch August 24, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerjg powerjg powerjg approved these changes

@shingarov shingarov shingarov approved these changes

Assignees

@powerjg powerjg

Labels
compilation error ext Components external to gem5 such as third-party code. Typically found in "ext" gdb The GNU Debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS build failure due to conflicting defines in gdbremote/signals.hh
3 participants
@BobbyRBruce @powerjg @shingarov