Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib: Integrate BootloaderKernelWorkload #630

Merged
merged 2 commits into from
Dec 2, 2023
Merged

stdlib: Integrate BootloaderKernelWorkload #630

merged 2 commits into from
Dec 2, 2023

Conversation

hnpl
Copy link
Contributor

@hnpl hnpl commented Nov 30, 2023 •
edited
Loading

This change does the following,

  • Change the name of several python parameter names of the RiscvBootloaderKernelWorkload. This is done to conform the expectation from the stdlib, e.g., the kernel path must be object_file, and the boot parameter must be command_line.
  • Use RiscvBootloaderKernelWorkload by default for all full system RISC-V simulations. RiscvBootloaderKernelWorkload is a superset of RiscvFsWorkload.

@hnpl
Copy link
Contributor Author

hnpl commented Nov 30, 2023 •
edited
Loading

This is a rough sketch of integrating the new workload type to the RISC-V board. It still has a bug where the base configure_workload function was called while it was configure_workload of the child class that should have been called.

Edit: the change has been revised and this is no longer a problem.

@Harshil2107 Harshil2107 mentioned this pull request Nov 30, 2023
Closed
42 tasks
@hnpl hnpl force-pushed the features/bootloader-workload-stdlib-integration branch from b3aad1e to 46b34fe Compare December 1, 2023 01:17
@hnpl hnpl marked this pull request as ready for review December 1, 2023 01:24
@hnpl hnpl changed the title Features/bootloader workload stdlib integration stdlib: Integrate BootloaderKernelWorkload Dec 1, 2023
@hnpl hnpl force-pushed the features/bootloader-workload-stdlib-integration branch 2 times, most recently from 614996d to 3a3cebb Compare December 1, 2023 07:27
@hnpl
arch-riscv: Rename BootloaderKernelWorkload parameters
bbe5216 
The gem5 standard library hardcoded some parameters of the workload.
E.g., the kernel filename must be `object_file`.

Change-Id: I5eeb7359be399138693eaba0738eaf524c59408f
Signed-off-by: Hoa Nguyen <hn@hnpl.org>
@hnpl
stdlib: Integrate BootloaderKernelWorkload
be3163a 
Change-Id: Ifeaa98059d5667c3335eaccd57a5295f44f88e43
Signed-off-by: Hoa Nguyen <hn@hnpl.org>
@hnpl hnpl force-pushed the features/bootloader-workload-stdlib-integration branch from 3a3cebb to be3163a Compare December 1, 2023 07:28
@powerjg powerjg mentioned this pull request Dec 1, 2023
Merged
powerjg
powerjg approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@powerjg powerjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. More testing would be nice. I suppose we can do that on the staging branch, though.

@BobbyRBruce BobbyRBruce merged commit 48f3cd1 into gem5:develop Dec 2, 2023
33 checks passed
@hnpl hnpl deleted the features/bootloader-workload-stdlib-integration branch December 16, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerjg powerjg powerjg approved these changes

@BobbyRBruce BobbyRBruce BobbyRBruce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hnpl @powerjg @BobbyRBruce