Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch-riscv: Use TeX's escape seq in Python instead of Unicode #985

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

hnpl
Copy link
Contributor

@hnpl hnpl commented Apr 1, 2024

Currently, the citation string has a Unicode character. This works well in gem5, but it breaks the gem5+SST simulation [1]. This change modifies the letter "u" with umlaut to use TeX's escape sequence for this letter instead of using the UTF-8 character.

[1] #982

Currently, the citation string has a Unicode character. This works
well in gem5, but it breaks the gem5+SST simulation [1]. This change
modifies the letter "u" with umlaut to use TeX's escape sequence for
this letter instead of using the UTF-8 character.

[1] gem5#982

Change-Id: I44c0234afed9d8f7c8079d83ec36383abd2219f5
Signed-off-by: Hoa Nguyen <hn@hnpl.org>
@hnpl hnpl changed the title arch-riscv: Use escape char in Python string instead of Unicode char arch-riscv: Use TeX's escape seq in Python instead of Unicode Apr 1, 2024
@hnpl hnpl mentioned this pull request Apr 1, 2024
@ivanaamit ivanaamit linked an issue Apr 2, 2024 that may be closed by this pull request
@ivanaamit ivanaamit added the arch-riscv The RISC-V ISA label Apr 2, 2024
Copy link
Contributor

@tommarin tommarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerjg powerjg merged commit 6288268 into gem5:develop Apr 2, 2024
34 of 42 checks passed
@hnpl hnpl deleted the citation-unicode branch April 9, 2024 23:22
mjkpolo pushed a commit to mjkpolo/gem5 that referenced this pull request Apr 15, 2024
Currently, the citation string has a Unicode character. This works well
in gem5, but it breaks the gem5+SST simulation [1]. This change modifies
the letter "u" with umlaut to use TeX's escape sequence for this letter
instead of using the UTF-8 character.

[1] gem5#982

Signed-off-by: Hoa Nguyen <hn@hnpl.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-riscv The RISC-V ISA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SST Support is Broken
4 participants