-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to generate testnet addresses #10
Comments
According to #8, the node = MoneyTree::Node.from_bip32(master_node).node_for_path(node_path)
node.to_address(true, network: :bitcoin_testnet) I think it's unfortunate that the network information encoded in the bip32 is just lost. Maybe it could be preserved and used as the default network for |
@mhanne is correct – moneytree aims to be a currency-agnostic library.
We find it better to use the path structure to indicate network per bip44 unless you're running in a constrained environment where the key derivation operation is very expensive (and if that's the case, why use ruby?) and to be explicit when (de)serializing. |
That's also why this was released as a minor version with a breaking change. |
Ok, I'll guess I'll stick with a sane version of the gem then. It's still not very clear why such a breaking change was released as a minor version bump, because being backwards-compatible usually means "the same stuff will keep working", and not "you'll still be able to achieve similar functionality by doing things in different way" as it seems implied here. |
Per semver.org:
We use minor versions to indicate breaking changes for all versions < 1.0.0 — sorry for your confusion. |
I used to be able to retrieve testnet adresses...
This doesn't work anymore either with this syntax, or with the new "from_bip32" syntax, which are just synonyms anyway. Main net addresses are returned.
The text was updated successfully, but these errors were encountered: