Remove network state #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Money-Tree, in essence is a key-derivation tool. The keys it derives are not aware of the 'coin', or 'version'. So there is now no notion of network held as state on anything. Money-Tree derives keys, and in the various forms of serialization you can specify which type of coin (version bytes) you'd like to use. Although it may seem tedious, it allows trees to be coin-agnostic until serialization (and theoretically the usage of the same key-pairs for different coin addresses.)
If the user provides a NETWORK that is not recognized, we throw an error.
Rename to_serialized_address to to_bip32 same for from_serialized_address. Deprecate old methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Money-Tree, in essence is a key-derivation tool.
The keys it derives are not aware of the 'coin',
or 'version'. So there is now no notion of network
held as state on anything.
Money-Tree derives keys, and in the various forms of serialization
you can specify which type of coin (version bytes) you'd like to use.
Although it may seem tedious, it allows trees to be
coin-agnostic until serialization (and theoretically
the usage of the same key-pairs for different coin
addresses.)