removed timeouts on http_client when uploading. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per recommendations at https://github.com/nahi/httpclient, have set the send_timeout and receive_timeout to 0 when uploading large files: LIMITATION: timeout occurs certainly when you send very large file and @send_timeout is default since HTTPClient::Session#query() assumes that *all* write are finished in @send_timeout sec not each write. WORKAROUND: increment @send_timeout and @receive_timeout or set @send_timeout and @receive_timeout to 0 not to be timeout.
|
Hey Tom, Just wondering if you've had a chance to look at this? Any chance of getting it merged in with a release? :) Anything I can do to help? |
tomlea
added a commit
that referenced
this pull request
Jan 20, 2013
removed timeouts on http_client when uploading.
|
Sorry for the delay, I appear to be a caricature of a bad project maintainer. |
|
:) no worries. Thanks for getting this pulled in. Very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per recommendations at https://github.com/nahi/httpclient, have set the send_timeout and receive_timeout to 0 when uploading large files:
LIMITATION:
timeout occurs certainly when you send very large file and
@send_timeout is default since HTTPClient::Session#query() assumes
that all write are finished in @send_timeout sec not each write.
WORKAROUND:
increment @send_timeout and @receive_timeout or set @send_timeout and
@receive_timeout to 0 not to be timeout.