Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Commit

Permalink
feat(calibrator): move to gemini-core
Browse files Browse the repository at this point in the history
  • Loading branch information
DudaGod committed Jan 12, 2018
1 parent 5006927 commit e884c19
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 291 deletions.
3 changes: 1 addition & 2 deletions lib/browser-pool.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict';

const BrowserPool = require('gemini-core').BrowserPool;
const Calibrator = require('./calibrator');
const {BrowserPool, Calibrator} = require('gemini-core');
const Browser = require('./browser');
const Events = require('./constants/events');

Expand Down
10 changes: 4 additions & 6 deletions lib/browser/camera.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,10 @@ module.exports = class Camera {
return image;
}

return image.crop({
left: this._calibration.left,
top: this._calibration.top,
width: image.getSize().width - this._calibration.left,
height: image.getSize().height - this._calibration.top
});
const {left, top} = this._calibration;
const {width, height} = image.getSize();

return image.crop({left, top, width: width - left, height: height - top});
}

_cropToViewport(image, page) {
Expand Down
63 changes: 0 additions & 63 deletions lib/browser/client-scripts/gemini.calibrate.js

This file was deleted.

140 changes: 0 additions & 140 deletions lib/calibrator.js

This file was deleted.

6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@
"debug": "^2.2.0",
"fs-extra": "^0.30.0",
"gemini-configparser": "^1.0.0",
"gemini-core": "^2.2.1",
"gemini-core": "^2.3.0",
"gemini-coverage": "^1.0.0",
"graceful-fs": "^4.1.11",
"handlebars": "^4.0.5",
"inherit": "~2.2.1",
"js-yaml": "^3.2.5",
"lodash": "^4.15.0",
"looks-same": "^3.0.0",
"micromatch": "^2.3.11",
"node-fetch": "^1.6.3",
"plugins-loader": "^1.1.0",
Expand All @@ -35,7 +34,6 @@
"sizzle": "^2.2.0",
"source-map": "^0.5.3",
"striptags": "2.1.1",
"uglify-js": "^2.7.3",
"uglifyify": "^3.0.1",
"wd": "^0.4.0",
"worker-farm": "^1.3.1"
Expand All @@ -60,8 +58,6 @@
},
"scripts": {
"test-unit": "istanbul test _mocha -- --recursive test/unit",
"prepublish": "npm run prepare-calibrate-script",
"prepare-calibrate-script": "uglifyjs ./lib/browser/client-scripts/gemini.calibrate.js -m > ./lib/browser/client-scripts/gemini.calibrate.min.js --support-ie8",
"postpublish": "npm run publish-site",
"test-func": "istanbul test _mocha test/functional",
"test-browser": "istanbul test _mocha test/browser",
Expand Down
5 changes: 3 additions & 2 deletions test/browser/calibrator.test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';
var eachSupportedBrowser = require('./util').eachSupportedBrowser,
Calibrator = require('lib/calibrator');

const {eachSupportedBrowser} = require('./util');
const {Calibrator} = require('gemini-core');

describe('calibrator', function() {
eachSupportedBrowser(function() {
Expand Down
Binary file removed test/functional/data/image/calibrate-broken.png
Binary file not shown.
Binary file removed test/functional/data/image/calibrate.png
Binary file not shown.
3 changes: 1 addition & 2 deletions test/unit/browser-pool.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

const BrowserPool = require('lib/browser-pool');
const BrowserFabric = require('lib/browser');
const Calibrator = require('lib/calibrator');
const RunnerEvents = require('lib/constants/events');
const CoreBrowserPool = require('gemini-core').BrowserPool;
const {BrowserPool: CoreBrowserPool, Calibrator} = require('gemini-core');
const AsyncEmitter = require('gemini-core').events.AsyncEmitter;
const _ = require('lodash');
const Promise = require('bluebird');
Expand Down
2 changes: 1 addition & 1 deletion test/unit/browser/new-browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const _ = require('lodash');

const Camera = require('lib/browser/camera');
const ClientBridge = require('lib/browser/client-bridge');
const Calibrator = require('lib/calibrator');
const {Calibrator} = require('gemini-core');
const WdErrors = require('lib/constants/wd-errors');
const GeminiError = require('lib/errors/gemini-error');

Expand Down
70 changes: 0 additions & 70 deletions test/unit/calibrator.test.js

This file was deleted.

0 comments on commit e884c19

Please sign in to comment.