This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Don't catch all exceptions in coverage script #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing it with return value causes coverage processing to crash with completely undescriptive error. Errors will be caught by prepareScreenshot anyway, so there is really no need to do it collectCoverage anyway.
|
🆗 |
SevInf
pushed a commit
that referenced
this pull request
Apr 24, 2015
Don't catch all exceptions in coverage script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing it with return value causes coverage processing to crash
with completely undescriptive error.
Errors will be caught by prepareScreenshot anyway, so there is really
no need to do it collectCoverage anyway.
/cc @scf2k @Cody0