feat: add ability to specify ignoreDiffPixelCount in assertView #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
changed the title
KuznetsovRoman
force-pushed
the
HERMIONE-1403.max_pixels_diff
branch
5 times, most recently
from
b690cfd
to
d747364
Compare
KuznetsovRoman
commented
Feb 22, 2024
| @@ -25,5 +34,16 @@ exports.handleImageDiff = (currImg, refImg, state, opts) => { | |||
| ...buildDiffOpts, | |||
| }; | |||
|
|
|||
| return Promise.reject(ImageDiffError.create(state, currImg, refImg, diffOpts, diffAreas, diffBuffer)); | |||
| return Promise.reject( | |||
| ImageDiffError.create({ | |||
There was a problem hiding this comment.
Changed this method's params to be a single object. This would be passed into html-reporter
KuznetsovRoman
commented
Feb 22, 2024
src/browser/commands/types.ts
Outdated
| * | ||
| * @defaultValue `0` | ||
| */ | ||
| maxDiffPixels?: `${number}%` | number; |
There was a problem hiding this comment.
Turns out, you can do such things in typescript.
Using `${number}%` | number directly, without extra type, because this way you can get clear understanding about what type this field wants value to be:
KuznetsovRoman
changed the title
sipayRT
approved these changes
Feb 22, 2024
src/browser/commands/types.ts
Outdated
| * @example '1.5%' | ||
| * | ||
| * @remarks | ||
| * Usefull, when you have 2-5 different pixels you can't get rid of using `tolerance` and `antialiasingTolerance`. |
There was a problem hiding this comment.
меня здесь смущает связка "get rid of using tolerance". Выше писал как можно перефразировать
KuznetsovRoman
force-pushed
the
HERMIONE-1403.max_pixels_diff
branch
from
4602301
to
31372d9
Compare
KuznetsovRoman
changed the title
KuznetsovRoman
force-pushed
the
HERMIONE-1403.max_pixels_diff
branch
2 times, most recently
from
7cf5930
to
7a7230d
Compare
sipayRT
reviewed
Feb 27, 2024
sipayRT
reviewed
Feb 27, 2024
KuznetsovRoman
force-pushed
the
HERMIONE-1403.max_pixels_diff
branch
from
7a7230d
to
32242e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
Implemented
ignoreDiffPixelCountoptional param toassertViewcommand.With there params, it would be possible to ignore 2-5 pixel image diffs, which are hard to get rid of
Example: