feat(ct): support hot module replacement #936
Conversation
DudaGod
force-pushed
the
HERMIONE-1507.support_hmr
branch
2 times, most recently
from
baf74bb
to
a2c9c66
Compare
| @@ -115,7 +115,7 @@ | |||
| "@types/node": "18.19.3", | |||
| "@types/proxyquire": "1.3.28", | |||
| "@types/sharp": "0.31.1", | |||
| "@types/sinon": "4.3.3", | |||
| "@types/sinon": "17.0.1", | |||
There was a problem hiding this comment.
We already use sinon 17.0.1, so I update types in order to use clock.tickAsync
| @@ -63,6 +63,8 @@ export default (browser: Browser): void => { | |||
| const replServer = repl.start({ prompt: "> " }); | |||
| browser.applyState({ onReplMode: true }); | |||
|
|
|||
| runtimeCfg.extend({ replServer }); | |||
There was a problem hiding this comment.
Add replServer to runtime config in order to be able to stop it if test reconnected in repl mode. I do it because after rerun test replServer opens again and this leads to conflict with new repl server
| @@ -49,6 +49,11 @@ const getErrors = (errors: ViteError | ViteError[] = []): ViteError[] => { | |||
| }; | |||
|
|
|||
| export const getErrorsOnPageLoad = (initError?: Error): ErrorOnPageLoad[] => { | |||
| // ignore error because in this case vite runtime error has more details | |||
| if (initError && initError.message.includes("Failed to fetch dynamically imported module")) { | |||
There was a problem hiding this comment.
I found that this error is not very informative
| const connectToSocket = (): BrowserViteSocket => { | ||
| const socket = io({ | ||
| auth: { | ||
| runUuid: window.__testplane__.runUuid, | ||
| type: BROWSER_EVENT_PREFIX, | ||
| reconnect: Boolean(sessionStorage.getItem(RECONNECT_KEY)), // TODO: move reconnect field to constant ???? |
There was a problem hiding this comment.
I use reconnect flag in session storage in order to be able to understand if vite/user refresh page with test or not.
| this._broInitResOnReconnect = errors; | ||
| }); | ||
|
|
||
| if (this._browser.state.onReplMode) { |
There was a problem hiding this comment.
If repl mode is used I need close previous repl server in order to not conflict with new one, which opens on rerun runnables
| }, BRO_INIT_INTERVAL_TIMEOUT_ON_RECONNECT).unref(); | ||
| }) | ||
| .timeout( | ||
| BRO_INIT_TIMEOUT_ON_RECONNECT, |
There was a problem hiding this comment.
Here I wait only 5 seconds because it should works fast. New url is not open and just refreshed in the same browser tab
| _getPreparePageActions(browser: Browser, history: BrowserHistory): (() => Promise<void>)[] { | ||
| if (this._isReconnected) { | ||
| return super._getPreparePageActions(browser, history); |
There was a problem hiding this comment.
Do not open page again and subscribe on events like callConsoleMethod or runBrowserCommand if browser was reconnected
| async run({ sessionId, sessionCaps, sessionOpts, state, ExecutionThreadCls = ExecutionThread }) { | ||
| const test = this._test; | ||
| const testplaneCtx = test.testplaneCtx || {}; | ||
| async run({ sessionId, sessionCaps, sessionOpts, state }) { |
There was a problem hiding this comment.
Here I just split this method on three: prepareToRun, runRunnables and finishRun. Code inside them remained the same.
| } | ||
|
|
||
| // TODO: make it protected | ||
| async prepareToRun({ sessionId, sessionCaps, sessionOpts, state }) { |
There was a problem hiding this comment.
I want to use these methods in BrowserTestRunner and stub them. So I want make these methods protected but it is on javascript. Therefore, I left todo here for now
| socketClientStub.returns(socket); | ||
|
|
||
| const promise = run_(); | ||
| await clock.tickAsync(1); |
There was a problem hiding this comment.
used in order to give event loop ability to run source code (subscribe on initialize event)
DudaGod
force-pushed
the
HERMIONE-1507.support_hmr
branch
from
a2c9c66
to
059eb55
Compare
DudaGod
force-pushed
the
HERMIONE-1507.support_hmr
branch
from
059eb55
to
7bbf0f4
Compare
What is done
Vite which is used inside component tests support hmr (hot module replacement) it means that it can reload page if something changed (for example if user modify test file). So in this PR I implement ability to rerun test runnables if vite reload page with test.