Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Xtext validators resilient #149

Closed
echebbi opened this issue Jun 26, 2020 · 0 comments · Fixed by #155
Closed

Make Xtext validators resilient #149

echebbi opened this issue Jun 26, 2020 · 0 comments · Fixed by #155
Assignees
@echebbi
Labels
affect: editor affect: validators Related to Xtext validators bug prio - top
Milestone
Stabilize public ...

Comments

@echebbi
Copy link
Collaborator

echebbi commented Jun 26, 2020

Motivation

An unexpected exception in a validator is:

  • uncaught, hence stopping the whole validation,
  • swallowed, hence not reported to the user.

Proposition

Make sure that an Exception cannot stop the execution (granularity: method) and that errors are reported to the Error Logs view.
@echebbi echebbi mentioned this issue Jun 26, 2020
Closed
@echebbi echebbi self-assigned this Jun 26, 2020
echebbi added a commit that referenced this issue Jun 26, 2020
@echebbi
[Editor] Make Xtext validators resilient (fix #149)
2d98e36 
Because:
 - unexpected exceptions in a validator were stopping the whole validation

How:
 - SafeValidator can be used to decorate IValidator and make their validation methods
   exception-proof
 - the possible absence of ExtendedClass::baseClass has been taken into account
   and is less likely to cause errors

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi added a commit that referenced this issue Jun 26, 2020
@echebbi
[Editor] Log internal errors during source file validation (#155)
5b5e633 
Because:
 - internal errors may crash source file validation without any error being log (#149)

How:
 - actually catch exceptions & log them through the Activator

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi added a commit that referenced this issue Jun 26, 2020
@echebbi
[Editor] Make Xtext validators resilient (#155)
f5ccffb 
Because:
 - unexpected exceptions in a validator were stopping the whole validation (#149)

How:
 - SafeValidator can be used to decorate IValidator and make their validation methods
   exception-proof
 - the possible absence of ExtendedClass::baseClass has been taken into account
   and is less likely to cause errors

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi added a commit that referenced this issue Jun 26, 2020
@echebbi
[Editor] Make Xtext validators resilient (#155)
f43f801 
Because:
 - unexpected exceptions in a validator were stopping the whole validation (#149)

How:
 - SafeValidator can be used to decorate IValidator and make their validation methods
   exception-proof
 - the possible absence of ExtendedClass::baseClass has been taken into account
   and is less likely to cause errors

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
@echebbi echebbi mentioned this issue Jun 26, 2020
Merged
echebbi added a commit that referenced this issue Jun 27, 2020
@echebbi
[Editor] Log internal errors during source file validation (#155)
4dbe256 
Because:
 - internal errors may crash source file validation without any error being log (#149)

How:
 - actually catch exceptions & log them through the Activator

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi added a commit that referenced this issue Jun 27, 2020
@echebbi
[Editor] Make Xtext validators resilient (#155)
28f307e 
Because:
 - unexpected exceptions in a validator were stopping the whole validation (#149)

How:
 - SafeValidator can be used to decorate IValidator and make their validation methods
   exception-proof
 - the possible absence of ExtendedClass::baseClass has been taken into account
   and is less likely to cause errors

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
@echebbi echebbi mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@echebbi echebbi

Labels
affect: editor affect: validators Related to Xtext validators bug prio - top
Projects
None yet
Milestone
Stabilize public and internal APIs
Development

Successfully merging a pull request may close this issue.

Make Xtext validators resilient gemoc/ale-lang
1 participant
@echebbi