Decouple ALE environment from .dsl file #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echebbi
added a commit
that referenced
this pull request
Mar 10, 2020
…rface (#115) An "ALE environment" being the couple (ALE source files ; Ecore models) used by the editor/interpreter. Because: - will ease implementation of incoming features requiring smoother management of the environment e.g. loading an environment from preferences instead of from a DSL configuration file. Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
added a commit
that referenced
this pull request
Mar 10, 2020
Because: - allows to load multiple ALE source files at once - allows ALE source files and DSL configuration files to have different names (fix #4) - allows to get rid of the DSL file (environment can be set from project's properties) How: - provide a new IAleEnvironment interface that abstracts away the way ALE source files and Ecore models are gathered - provide a new AleEnvironmentPropertyPage that allows to set the environment Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
force-pushed
the
4-decouple-ALE-env-from-DSL
branch
from
b240e2f
to
17fa3a1
Compare
echebbi
added a commit
that referenced
this pull request
Mar 10, 2020
Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
…rface (#115) An "ALE environment" being the couple (ALE source files ; Ecore models) used by the editor/interpreter. Because: - will ease implementation of incoming features requiring smoother management of the environment e.g. loading an environment from preferences instead of from a DSL configuration file. Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
added a commit
that referenced
this pull request
May 2, 2020
Because: - allows to load multiple ALE source files at once - allows ALE source files and DSL configuration files to have different names (fix #4) - allows to get rid of the DSL file (environment can be set from project's properties) How: - provide a new IAleEnvironment interface that abstracts away the way ALE source files and Ecore models are gathered - provide a new AleEnvironmentPropertyPage that allows to set the environment Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
force-pushed
the
4-decouple-ALE-env-from-DSL
branch
from
17fa3a1
to
5662824
Compare
echebbi
added a commit
that referenced
this pull request
May 2, 2020
Because: - this wizard should allow to choice between an environment based on a .dsl configuration file and an environment based on project's preferences Also: - perform some code improvements & tests fix Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
Because: - allows to load multiple ALE source files at once - allows ALE source files and DSL configuration files to have different names (fix #4) - allows to get rid of the DSL file (environment can be set from project's properties) How: - provide a new IAleEnvironment interface that abstracts away the way ALE source files and Ecore models are gathered - provide a new AleEnvironmentPropertyPage that allows to set the environment Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
Because: - this wizard should allow to choice between an environment based on a .dsl configuration file and an environment based on project's preferences Also: - perform some code improvements & tests fix Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
Because: - its layout does not follow the new default layout Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
Because: - broken by recent changes related to ALE environement management Changes: - Sirius' Behavior layer is not automatically updated anymore and requires a manual Refresh - dynamic EReferences (declared in ALE) are not represented as edges anymores Those changes are due to the fact that ALE's environment may not be stored in a .dsl configuration file anymore. Hence, the AleResource that was used so far has been replaced by calls to an IAleEnvironment. Without the resource, Sirius is not automatically refreshed anymore. For the EReferences I'm not sure through. Looks like they are managed by Services::getSource and Services::getTarget but these methods are never called and I don't know why. Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
force-pushed
the
4-decouple-ALE-env-from-DSL
branch
from
5662824
to
eb174eb
Compare
echebbi
added a commit
that referenced
this pull request
May 2, 2020
…rface (#115) An "ALE environment" being the couple (ALE source files ; Ecore models) used by the editor/interpreter. Because: - will ease implementation of incoming features requiring smoother management of the environment e.g. loading an environment from preferences instead of from a DSL configuration file. Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
added a commit
that referenced
this pull request
May 2, 2020
Because: - allows to load multiple ALE source files at once - allows ALE source files and DSL configuration files to have different names (fix #4) - allows to get rid of the DSL file (environment can be set from project's properties) How: - provide a new IAleEnvironment interface that abstracts away the way ALE source files and Ecore models are gathered - provide a new AleEnvironmentPropertyPage that allows to set the environment Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
added a commit
that referenced
this pull request
May 2, 2020
Because: - this wizard should allow to choice between an environment based on a .dsl configuration file and an environment based on project's preferences Also: - perform some code improvements & tests fix Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
added a commit
that referenced
this pull request
May 2, 2020
Because: - its layout does not follow the new default layout Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
This was referenced Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #108 to be merged first
Close #4.
Changes
AleValidatordoes not require the DSL configuration file and ALE source file to have the same name anymoreProgress
Allow multiple ALE source filesEnhance the New Project wizard to:create projects with the new ALE naturecreate ALE source files in asrc/foldernot create a DSL configuration file by defaultTestsScreenshot