Properly turn AQL declarations into EMF objects #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upper bound (#129) Because: - until now, AQL collections were turned into EEList datatypes with [0, 1] bounds. this is not standard and makes harder to deal with collections - it should allow for simplifying the code, especially in the type checker Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
…d method (#129) Because: - 'result' is not available in a void method - a warning is already shown when using := operator Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
echebbi
force-pushed
the
properly-turn-AQL-declarations-into-EMF-objects
branch
from
9479393
to
72f610f
Compare
echebbi
added a commit
that referenced
this pull request
May 6, 2020
…upper bound (#129) Because: - until now, AQL collections were turned into EEList datatypes with [0, 1] bounds. this is not standard and makes harder to deal with collections - it should allow for simplifying the code, especially in the type checker Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
Little refactor of the parser (
ModelBuilder) to create a cleaner EMF model.As of now, AQL collections are turned into EDataType instances holding an EEList type and with bounds [0, 1]. This commit turns collections into ETypedElement holding the actual type with relevant bounds instead.
This homogenize datatypes and should ease further developments, e.g. to handle Sets properly (#67).
Bonus
Also provides a little enhancement: using
+=or-=on theresultvariable within a void operation now leads to the following error: 'result' is not available in a void method. Change method's return type.The error was already shown when using the
:=operator.