Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Eclipse 2020 03 #138

Merged
merged 9 commits into from
Jun 19, 2020
Merged

Bump to Eclipse 2020 03 #138

merged 9 commits into from
Jun 19, 2020

Conversation

dvojtise
Copy link
Contributor

@dvojtise dvojtise commented May 20, 2020

This PR upgrades several versions in order to match those used in Eclipse 2020-03

  • change target platform to use Eclipse 2020-03 update site
  • bump xtend to 2.21.0
  • bump tycho to 1.7.0
  • bump Sirius to 6.3.0 (close Doesn't work with Sirius 6.2.0 and higher #87)
  • increase version number of all ALE plugins to indicate the new api requirement

It also does some adaptation implied by Sirius API change:

The one that may require some verification is about the use of org.eclipse.sirius.common.tools.api.interpreter.EvaluationResult.ofValue in ALEInterpreter

@dvojtise
Copy link
Contributor Author

dvojtise commented May 20, 2020

Changed the use of EvaluationResult.ofValue by a dedicated OptimizedEvaluationResult implementation in order to keep the same behavior as before.

CI is OK (all tests pass)

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
use sirius.common.tools.api.interpreter.EvaluationResult

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
change target platform to eclipse 2020-03
bump xtend to 2.21.0
bump tycho to 1.7.0
bump sirius to 6.3.0
increase version number of ALE plugins to indicate the new api
requirement

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
this class helps to decrease diagnostic depth in simple cases

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
@echebbi
Copy link
Collaborator

echebbi commented Jun 4, 2020

I'm updating the PR to master (PR #136 and #137 have moved some things around). Should I push force this PR or commit the changes on another branch so that you can check them first?

@dvojtise
Copy link
Contributor Author

dvojtise commented Jun 4, 2020 via email

@dvojtise
Copy link
Contributor Author

dvojtise commented Jun 4, 2020 via email

Signed-off-by: Emmanuel Chebbi <emmanuel.chebbi@outlook.fr>
@echebbi
Copy link
Collaborator

echebbi commented Jun 5, 2020

The branch is now up-to-date

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
these classes offer some services to GEMOC that need to be refined in a
clear API

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
@dvojtise dvojtise merged commit 540e1b3 into master Jun 19, 2020
@echebbi echebbi mentioned this pull request Jun 23, 2020
@dvojtise dvojtise deleted the bump-to-eclipse-2020-03 branch July 17, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work with Sirius 6.2.0 and higher
2 participants