fix #164 and respect ratelimit for bulk joins #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deefdragon
reviewed
Oct 26, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ence implementations, I'm sure this will be fine Clueless
deefdragon
reviewed
Dec 18, 2021
| } | ||
| } | ||
|
|
||
| func (r *RateLimiter) Throttle() { | ||
| func (r *RateLimiter) Throttle(count int) { |
There was a problem hiding this comment.
Should there be a mutex on this internally to the ratelimiter, or is it/are you planning on handling it externally?
There was a problem hiding this comment.
The writer runs in with channel so there should be not concurrent access of this function
pajlada
reviewed
Dec 19, 2021
Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
pajlada
reviewed
Dec 19, 2021
| } | ||
| if sb.Len() == len(baseMessage) { | ||
| sb.WriteString(" #" + channel) | ||
| channelsWritten++ |
There was a problem hiding this comment.
Would it be more clear to increment channelsWritten after the if-else? I'm not sold on moving it or leaving it as is myself
There was a problem hiding this comment.
I was unsure as well, but this is probably good.
In a way it also documents each branch of the if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ratelimiting implemented based on a slice with times in it. All the other examples of sliding window implementations looked super complicated to me and not so straight forward.
I'm not sure if this is the correct way to solve this problem, but at least my tests run now. Which they haven't done for any implementation before as you can see by the build history.
One slight weird thing still is I added a 100ms extra sleep, because on CI it kept failing, locally I could run it fine. This is slightly alarming because I'm wondering if on different systems it could behave even differently.
But running
go test -racebrings up no issues.